Parse JSON false as :json-false instead of nil #4191
Conversation
This would break code actions where the server sends us an action containing a `false` boolean parameter. `lsp-mode` would translate this into `nil`, and then send a `null` back to the language server. An example of this causing problems was emacs-lsp#4184. There may be parts of `lsp-mode` that expect `false` values to be parsed as `nil`, so any logic involving parsed booleans may need to be updated.
|
This indeed causes problems elsewhere in |
|
The preferred solution is to patch it in place. There are several other places where we have this issue. See: https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-completion.el#L694 |
|
Having to explicitly patch lsp-mode for every code action that uses booleans doesn't sound ideal, but somehow this doesn't seem to cause a lot of problems. In this case, does lsp-mode have a mechanism that lets this hack live in |
|
Technically you can put it wherever you want. I would suggest it to put in the place in which it will be easier to implement it. I believe it will be easier to put it in lsp-mode. Unfortunately, there is no alternative (easy) solution and we should go with this ugly approach... |
|
Superseded by #4194. |
This would break code actions where the server sends us an action containing a
falseboolean parameter.lsp-modewould translate this intonil, and then send anullback to the language server. An example of this causing problems was#4184.
There may be parts of
lsp-modethat expectfalsevalues to be parsed asnil, so any logic involving parsed booleans may need to be updated. I have not dug around much, so input from people who are more familiar withlsp-mode's internals is very much appreciated!Fixes #4184.