Add basic pull diagnostics support

[Ruin0x11]

Only basic support for now; no extra features like related documents. It's just enough to get diagnostics showing with the Roslyn server.

Closes #4276.

[jcs090218]

Can you resolve conflicts and rebase this? Thank you!

[catssay]

The newest version of eslint plugin also uses the feature. My project using latest eslint version 9.5.0, it doesn't work with eslint plugin version 2.2.2 which is lastest version lsp-eslint provided. So I downloaded the latest eslint plugin from vscode market and replaced it, but it not work. Then I applied the patch, it worked. It would be great if some can review and merge the code.

[Ruin0x11]

@jcs090218 Could you please take a look at this when you have some time? Thank you.

[sin-ack]

I just tested this patch and it doesn't seem to work with Roslyn language server version 4.11.0-3.24320.2. Weirdly enough, I don't see a textDocument/diagnostic message sent, neither by opening a file or changing it.

[jcs090218]

@jcs090218 Could you please take a look at this when you have some time? Thank you.

I'm sorry for not getting back to you sooner! I was a little busy recently.

Others have helped test this patch, but it doesn't work. 🤔 Can you confirm this?

[jcs090218]

There are compile errors:

In lsp-diagnostics--apply-pull-diagnostics:
lsp-mode.el:2340:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In lsp--after-change:
lsp-mode.el:4929:9: Warning: ‘mapcar’ called for effect; use ‘mapc’ or ‘dolist’ instead

[Ruin0x11]

For me at least, I do get diagnostics with csharp-roslyn server:

I'm using version 4.9.0-3.23604.10 of that server on Windows.

[jcs090218]

Thank you!