Proposal: make it easier to work with dotnet tools for C#/F# #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @razzmatazz WDYT? 🤔 |
This commit allows users of this code to add extra directories to be ignored during project loading, which can be extremely useful while also using toolsets like Nix (which may symlink other F# projects in to the repo, thus confounding project loading).
This commit implements an approach proposed in emacs-lsp#3906. Specifically, it provides new control variables to make it possible to use C# and F# language servers _either_ as global _or_ local dotnet tools. So far, I've done this by providing boolean variables to control command construction, but I'm not attached to this approach. Closes emacs-lsp#3906.
Gastove
force-pushed
the
proposal/clean-up-dotnet-tool-management
branch
from
a7e8932
to
c6c272d
Compare
|
Hi y'all -- I think @razzmatazz / @yyoncho are the right "y'all" here. I've just rebased this branch so it's merge-able again. What do I need to do to get this merged? At this point, I think I've rebased my proposed changes from #4049 in here, and this PR now closes #4049 as well. |
jcs090218
reviewed
Jul 7, 2024
clients/lsp-csharp.el
Outdated
| (if lsp-csharp-csharpls-use-local-tool | ||
| "dotnet tool list" | ||
| "dotnet tool list -g"))) | ||
| ) |
There was a problem hiding this comment.
Let's place the ) on the last line.
There was a problem hiding this comment.
Oh my lord, how did that get there 😆 🤦 Yes! One second.
|
Can you resolve these compile errors? |
Absolutely. |
jcs090218
approved these changes
Jul 7, 2024
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements an approach proposed in #3906. Specifically, it provides new control variables to make it possible to use C# and F# language servers either as global or local dotnet tools. So far, I've done this by providing boolean variables to control command construction, but I'm not attached to this approach.
Closes #3906.