Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-xml: add supports for native binary language server #4396

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

kiennq
Copy link
Member

@kiennq kiennq commented Mar 27, 2024

The xml language server that's created by Redhat doesn't require Java.
We can add that as a compliment to the current jar version.

Looking at the vscode, it does the switch between jar version and native version based on java is available or not, I used the same approach here instead of creating a new xml language server declaration.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Mar 27, 2024
@kiennq
Copy link
Member Author

kiennq commented Mar 27, 2024

@jcs090218, @yyoncho, the test for 26.x is not running due to it has been dropped from support.
Can you remove those rules for merge as well?

@jcs090218
Copy link
Member

I don't have the permission. @yyoncho and @ericdallo have it.

@ericdallo
Copy link
Member

@jcs090218 I gave you owner permission too, since you are quite active in lsp-mode for some time :)

@jcs090218
Copy link
Member

@jcs090218 I gave you owner permission too, since you are quite active in lsp-mode for some time :)

That's very kind! Thank you! :D

@jcs090218
Copy link
Member

jcs090218 commented Mar 28, 2024

Can you remove those rules for merge as well?

@kiennq It's gone now. :)

clients/lsp-xml.el Outdated Show resolved Hide resolved
@jcs090218
Copy link
Member

There are compile errors:

In toplevel form:
lsp-xml.el:355:1:Warning: defcustom for ‘lsp-xml-server-command’ fails to
    specify type
lsp-xml.el:355:1:Warning: defcustom for ‘lsp-xml-server-command’ fails to
    specify type

@kiennq kiennq merged commit 09f548c into emacs-lsp:master Mar 29, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants