-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base QML setup #4412
Base QML setup #4412
Conversation
A few steps are missing; you can use this PR: #4385 as the reference. |
Sorry 🙁 Seems like I forget these every time I try to add a new client.... Added it now in newest commit 🙂 Unsure which server URL to use, as these are installed together with the rest of the Qt tooling when installing. |
Normally, we want to point to documentation or instruction. LGTM, though. |
Good thing I pointed to a documentation page then 😄 🎆 |
clients/lsp-qml.el
Outdated
@@ -0,0 +1,43 @@ | |||
;;; lsp-qml.el --- description -*- lexical-binding: t; -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a reasonable description? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 🙂 Added a short version of the one I put in "Commentary"
LGTM, thank you! |
Fixes #4131. That issue wished for the some configuration for QML (Qt Modeling Language). I did not find any special configuration options for it, but just having a variable to configure makes life easier for the users (instead of duplicating lsp-register-clients in peoples private .emacs.d). I use qml-mode together with it, and it works quite well when I played around 🙂