Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base QML setup #4412

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Base QML setup #4412

merged 4 commits into from
Apr 1, 2024

Conversation

themkat
Copy link
Contributor

@themkat themkat commented Mar 31, 2024

Fixes #4131. That issue wished for the some configuration for QML (Qt Modeling Language). I did not find any special configuration options for it, but just having a variable to configure makes life easier for the users (instead of duplicating lsp-register-clients in peoples private .emacs.d). I use qml-mode together with it, and it works quite well when I played around 🙂

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Mar 31, 2024
@jcs090218
Copy link
Member

jcs090218 commented Mar 31, 2024

A few steps are missing; you can use this PR: #4385 as the reference.

@themkat
Copy link
Contributor Author

themkat commented Apr 1, 2024

A few steps are missing; you can use this PR: #4385 as the reference.

Sorry 🙁 Seems like I forget these every time I try to add a new client....

Added it now in newest commit 🙂 Unsure which server URL to use, as these are installed together with the rest of the Qt tooling when installing.

@jcs090218
Copy link
Member

Unsure which server URL to use, as these are installed together with the rest of the Qt tooling when installing.

Normally, we want to point to documentation or instruction. LGTM, though.

@themkat
Copy link
Contributor Author

themkat commented Apr 1, 2024

Unsure which server URL to use, as these are installed together with the rest of the Qt tooling when installing.

Normally, we want to point to documentation or instruction. LGTM, though.

Good thing I pointed to a documentation page then 😄 🎆

@@ -0,0 +1,43 @@
;;; lsp-qml.el --- description -*- lexical-binding: t; -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a reasonable description? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 🙂 Added a short version of the one I put in "Commentary"

@jcs090218 jcs090218 merged commit d3173ad into emacs-lsp:master Apr 1, 2024
11 of 14 checks passed
@jcs090218
Copy link
Member

LGTM, thank you!

@themkat themkat deleted the feature/qml branch April 1, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Qt/QML language server
2 participants