Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Alire support from lsp-mode Ada client. #4484

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

brownts
Copy link
Contributor

@brownts brownts commented Jun 26, 2024

Alire support is now available directly in the Ada Language Server and handles the functionality currently implemented in lsp-mode. In addition, when the project file is not specified by the LSP client, the language server will intelligently locate the project file using alr when an Alire configuration file exists. Therefore, the default setting of the project file has been changed (from "default.gpr" to nil) to enable the server to automatically locate the project file in normal situations. The server will also automatically find a project file for a non-Alire project if it uniquely exists in the root folder (i.e., no other project file exists in this folder). The new project file default setting provides for a better out-of-the-box configuration to support common situations.

See discussion #4468 for additional details.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Jun 26, 2024
Alire support is now available directly in the Ada Language Server and
handles the functionality currently implemented in lsp-mode.  In
addition, when the project file is not specified by the LSP client,
the language server will intelligently locate the project file using
`alr` when an Alire configuration file exists.  Therefore, the default
setting of the project file has been changed (from "default.gpr" to
nil) to enable the server to automatically locate the project file in
normal situations.  The server will also automatically find a project
file for a non-Alire project if it uniquely exists in the root
folder (i.e., no other project file exists in this folder).  The new
project file default setting provides for a better out-of-the-box
configuration to support common situations.
@brownts
Copy link
Contributor Author

brownts commented Jun 27, 2024

Moved the safety predicate for the lsp-defcustom to an autoload, so that it's available during .dir-locals.el processing, which occurs prior to the lsp package being loaded in hack-local-variables-hook.

@jcs090218 jcs090218 merged commit c7020ae into emacs-lsp:master Jun 28, 2024
10 of 13 checks passed
@jcs090218
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants