fix: lsp--find-workspaces-for workspace/executeCommand respects the target command #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget command
Calling
(lsp--find-workspaces-for '(:method "workspace/executeCommand"
:params (:command "arbitrary-command")))
would return *any* workspace that had the :executeCommandProvider capability
registerd.
This would result in a given command being forwarded for **all active
workspaces**. Some servers (such as ruff) would raise a KeyError for unknown
commands -- causing the minibuffer to, sometimes, show an error.
This change introduces a new :check-message callback that can be used in
lsp-method-requirements -- this callback receives the workspace and the
message to be sent.
Ths entry for workspace/executeCommand has been updated to check if the target
workspace can execute the required command.
|
Do you folks think this is the right approach to avoid sending commands that a server will reject? Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
would return any workspace that had the :executeCommandProvider capability registered.
This would result in a given command being forwarded for several active workspaces that wouldn't know how to handle that command. Some servers (such as ruff) would raise a KeyError for unknown commands -- causing the minibuffer to, sometimes, show an error.
This change introduces a new :check-message callback that can be used in lsp-method-requirements -- this callback receives the workspace and the message to be sent.
Ths entry for workspace/executeCommand has been updated to check if the target workspace can execute the required command.