Fix #4501: Auto adjust stale diagnostic ranges on document changes #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This map keeps track of overlays guarding the diagnostic ranges
2 tasks
Nonetheless it actually works on CI at the moment: https://github.com/emacs-lsp/lsp-mode/actions/runs/10130730283/job/28012482598?pr=4513
|
It is also compatible with the experimental support for code snippets inside org-mode documents, see |
|
Can you resolve conflicts? Thank you! |
done |
|
I tried this PR and when I add/remove a line (regardless of whether that line is in front of or behind the diagnostic) the diagnostics move for a split second but then completely disappear. I've checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the diagnostic ranges actual after document edits and before LSP sends an update (can take multiple seconds or even minutes for SonarLint C++ analysis), allocate an overlay for each diagnostic and use it as the reference for its range.
This change works well together with #4512, which spares the LSP server from playing catch-up with the user modifications.
lsp-diagnosticsandlsp--get-buffer-diagnosticsnow have an additional optional argument:update-ranges?that refreshes the diagnostic ranges.This fixes #4501.