Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update TS config #4531

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Update TS config #4531

wants to merge 2 commits into from

Conversation

jcs090218
Copy link
Member

Discussed on Discord.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Aug 26, 2024
@KaranAhlawat
Copy link
Sponsor

Doesn't seem to work if I just set lsp-typescript-import-module-specifler-preference to non-relative in my .dir-locals.el file

@KaranAhlawat
Copy link
Sponsor

KaranAhlawat commented Aug 26, 2024 •
edited
Loading

https://github.com/typescript-language-server/typescript-language-server/blob/master/docs/configuration.md

Looking at this, it looks like, workspace/didChangeConfiguration no longer supports the importModuleSpecifierPreference, and it has to be passed in the initializationOptions itself.

EDIT 1:
typescript-language-server/typescript-language-server#906
This pretty much confirms it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client One or more of lsp-mode language clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcs090218 @KaranAhlawat