Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp-asm: if executable is found there's no need to install it #4564

Merged
merged 2 commits into from
Sep 28, 2024
Merged

lsp-asm: if executable is found there's no need to install it #4564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e604e
lsp-asm: if executable is found there's no need to install it
caiquefigueiredo Sep 27, 2024
27ba3d0
Update CHANGELOG.org with lsp-asm change
caiquefigueiredo Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* Replace the per-interface ~(INTERFACE ...)~ pcase forms with a single,
unified ~(lsp-interface INTERFACE ...)~ form. The per-interface forms are no
longer generated. *This is a breaking change.* (See #4430.)
* If asm-lsp is installed, lsp-asm won't try to download it to cache store

** 9.0.0
* Add language server config for QML (Qt Modeling Language) using qmlls.
Expand Down
3 changes: 2 additions & 1 deletion clients/lsp-asm.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ Will update if UPDATE? is t."
(make-lsp-client
:new-connection (lsp-stdio-connection
#'lsp-asm--server-command
(lambda () (f-exists? lsp-asm-store-path)))
(lambda () (or (executable-find "asm-lsp")
(f-exists? lsp-asm-store-path))))
:major-modes lsp-asm-active-modes
:priority -1
:server-id 'asm-lsp
Expand Down
Loading