Remove trailing whitespace from `lsp-describe-thing-at-point' #4576
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Oct 4, 2024
|
I was wondering this myself in the linked issue. As far as I can see, describe-at-point is not used elsewhere. I'm fully open in not knowing where this trailing whitespace comes from (clangd, or some internal formatting?). For testing, if you on some whitespace-mode in lsp-help, there's some substantial but semi-random amount... |
|
There is a compile error: 🤔 |
When calling `lsp-describe-thing-at-point' trailing whitespace can leak into the help buffer. Depending on the face settings, this whitespace can be visibile. Instead of removing trailing whitespace at the end of the buffer, do so on a line-by-line basis. Fixes emacs-lsp#4572
wavexx
force-pushed
the
describe_trailing_whitespace
branch
from
1b1f051
to
7b71927
Compare
|
Didn't realize string-split is a "new" alias for split-string... fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling `lsp-describe-thing-at-point' trailing whitespace can leak into the help buffer. Depending on the face settings, this whitespace can be visibile.
Instead of removing trailing whitespace at the end of the buffer, do so on a line-by-line basis.
Fixes #4572