Expose lsp-bash-allowed-shell and improve warning #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `sh-shell` values that are filtered by `:activation-fn` configurable without needing to override `lsp-bash-check-sh-shell` This allows people to allow values like `bats` and also makes it slightly clearer why those values aren't supported by default when the major mode is, which took me a long time to debug.
To make it easier to debug situations where the `:major-mode` is supported but `:activation-fn` prevents the buffer from being supported for other reasons, such as `lsp-bash` rejecting an `sh-shell` value of `bats`.
github-actions
bot
added
documentation
client
Fix the following test:
Test lsp-mock-doc-changes-wrong-version condition:
(void-variable sh-shell)
By only checking `lsp-bash-allowed-shells` when `sh-shell` is bound to a
value. For reasons that I'm not entirely clear about, this was fine
previously when checking against a static list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4201
lsp-bash: Remove major mode duplication
These are already filtered by
:major-modesso there's no need tofilter them again in the
:activation-fn.:major-modeswas originally removed in:But then reintroduced in:
lsp-bash: Expose lsp-bash-allowed-shells
Make the
sh-shellvalues that are filtered by:activation-fnconfigurable without needing to override
lsp-bash-check-sh-shellThis allows people to allow values like
batsand also makes itslightly clearer why those values aren't supported by default when the
major mode is, which took me a long time to debug.
lsp-mode: Improve warning about :activation-fn
To make it easier to debug situations where the
:major-modeissupported but
:activation-fnprevents the buffer from being supportedfor other reasons, such as
lsp-bashrejecting ansh-shellvalue ofbats.