-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: inline completions #4623
base: master
Are you sure you want to change the base?
Commits on Nov 19, 2024
-
fix: avoid calling line-number-at-pos with a value past the end of th…
…e buffer When a overlay is displayed at the end of the buffer, (window-end) may return a value that is past the end of the buffer. Calling line-number-at-pos with a value outside of the buffer bounds raises an error.
Configuration menu - View commit details
-
Copy full SHA for 361255a - Browse repository at this point
Copy the full SHA 361255aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5caf44c - Browse repository at this point
Copy the full SHA 5caf44cView commit details
Commits on Nov 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7227d67 - Browse repository at this point
Copy the full SHA 7227d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33025a0 - Browse repository at this point
Copy the full SHA 33025a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c5fc21 - Browse repository at this point
Copy the full SHA 9c5fc21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b9d47d - Browse repository at this point
Copy the full SHA 2b9d47dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ee78c1 - Browse repository at this point
Copy the full SHA 5ee78c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4f0c7c - Browse repository at this point
Copy the full SHA b4f0c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b572b - Browse repository at this point
Copy the full SHA f5b572bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9783fd - Browse repository at this point
Copy the full SHA f9783fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 828875b - Browse repository at this point
Copy the full SHA 828875bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ff223 - Browse repository at this point
Copy the full SHA d3ff223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f13826 - Browse repository at this point
Copy the full SHA 8f13826View commit details
Commits on Nov 26, 2024
-
fix: avoid weird interactions with company-mode
Check if company is active before displaying the overlay -- hide it if so
Configuration menu - View commit details
-
Copy full SHA for 1d4b7c8 - Browse repository at this point
Copy the full SHA 1d4b7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 063fd89 - Browse repository at this point
Copy the full SHA 063fd89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f67185 - Browse repository at this point
Copy the full SHA 5f67185View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bab211 - Browse repository at this point
Copy the full SHA 3bab211View commit details -
feat: provide a method to inhibit inline completion mode
Add a list of predicates that can inhibit triggering inline completions -- e.g.: ```elisp (defun lsp-inline-completion-inhibit-if-company-active () (and (bound-and-true-p company-mode) (company--active-p))) (push 'lsp-inline-completion-inhibit-if-company-active lsp-inline-completion-inhibit-predicates) ```
Configuration menu - View commit details
-
Copy full SHA for da2d8c2 - Browse repository at this point
Copy the full SHA da2d8c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64e6a77 - Browse repository at this point
Copy the full SHA 64e6a77View commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a1e7d7d - Browse repository at this point
Copy the full SHA a1e7d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92281ed - Browse repository at this point
Copy the full SHA 92281edView commit details -
fix: do not assume that the server response is a hash table
Also, refactor how we parse the response, using pcase for a more explicit approach
Configuration menu - View commit details
-
Copy full SHA for 55d086a - Browse repository at this point
Copy the full SHA 55d086aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e81d72 - Browse repository at this point
Copy the full SHA 0e81d72View commit details -
refactor: extract company integration to a minor mode
Users can enable the lsp-inline-completion-company-integration-mode if they see fit. Other completion frontends may be customized via hooks, just as this minor mode does
Configuration menu - View commit details
-
Copy full SHA for a74edd4 - Browse repository at this point
Copy the full SHA a74edd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e210a - Browse repository at this point
Copy the full SHA 80e210aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c43167 - Browse repository at this point
Copy the full SHA 3c43167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 612e90e - Browse repository at this point
Copy the full SHA 612e90eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b19a8f1 - Browse repository at this point
Copy the full SHA b19a8f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 231b867 - Browse repository at this point
Copy the full SHA 231b867View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49895b7 - Browse repository at this point
Copy the full SHA 49895b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 312626e - Browse repository at this point
Copy the full SHA 312626eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79dd07c - Browse repository at this point
Copy the full SHA 79dd07cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e20df27 - Browse repository at this point
Copy the full SHA e20df27View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b38e0 - Browse repository at this point
Copy the full SHA f2b38e0View commit details
Commits on Nov 28, 2024
-
fix: ensure no state changes before triggering inline completion
lsp-inline-completion--after-change, added to lsp on-change hooks, is triggered on a timer by `lsp--after-change`. The inline completion maybe-display function is also triggered on a timer and it must check if the position and current buffer did not change since the change as actually occurred. We can not store this state in lsp-inline-completion--after-change because the user may have clicked somewhere before the timer activated it. This commit introduces a `lsp--after-change-vals` plist to store the context before the timers have been started. lsp-inline-completion--after-change then fetches these values and forward as arguments to the timer invocation of maybe-display, which then ensures that the state has not changed.
Configuration menu - View commit details
-
Copy full SHA for 08c4c8d - Browse repository at this point
Copy the full SHA 08c4c8dView commit details -
chore: no spinner on implicit inline completions
It is a distraction.
Configuration menu - View commit details
-
Copy full SHA for c560275 - Browse repository at this point
Copy the full SHA c560275View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3eeb087 - Browse repository at this point
Copy the full SHA 3eeb087View commit details -
Configuration menu - View commit details
-
Copy full SHA for 509f8ee - Browse repository at this point
Copy the full SHA 509f8eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e2fa3 - Browse repository at this point
Copy the full SHA 69e2fa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a5dc5c - Browse repository at this point
Copy the full SHA 8a5dc5cView commit details -
Auto-substitution of tabs to space did not use the correct number of spaces
Configuration menu - View commit details
-
Copy full SHA for 86abb87 - Browse repository at this point
Copy the full SHA 86abb87View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4243c2 - Browse repository at this point
Copy the full SHA a4243c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b582bd - Browse repository at this point
Copy the full SHA 2b582bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13f340c - Browse repository at this point
Copy the full SHA 13f340cView commit details
Commits on Nov 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b4cff81 - Browse repository at this point
Copy the full SHA b4cff81View commit details -
Configuration menu - View commit details
-
Copy full SHA for a109f34 - Browse repository at this point
Copy the full SHA a109f34View commit details