fix: delay copilot login check and avoid raising error #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be some issues with being too eager to check for the login. The server may not have been properly initialized, which results in an error being raised by lsp-copilot--authenticated-as. That seems to wreck havoc in the call stack and leave lsp in a weird state -- there is a copilot server running, there seems to be a client that can be restarted... but there is no workspace registered ... This change give some time for the server to spin up and avoids raising an error if the authentication request did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be some issues with being too eager to check for the login. The server may not have been properly initialized, which results in an error being raised by lsp-copilot--authenticated-as. That seems to wreck havoc in the call stack and leave lsp in a weird state -- there is a copilot server running, there seems to be a client that can be restarted... but there is no workspace registered ...
This change give some time for the server to spin up and avoids raising an error if the authentication request did not work.