Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom variables for expand depth #148

Merged
merged 2 commits into from
Apr 5, 2024
Merged

custom variables for expand depth #148

merged 2 commits into from
Apr 5, 2024

Conversation

marcantonio
Copy link
Contributor

Adds the following custom variables for setting expand depth for various lists:

  • lsp-treemacs-error-list-expand-depth
  • lsp-treemacs-call-hierarchy-expand-depth
  • lsp-treemacs-type-hierarchy-expand-depth
  • lsp-treemacs-java-deps-list-expand-depth

Issue #147

@marcantonio
Copy link
Contributor Author

Note that I didn't test lsp-treemacs-type-hierarchy or lsp-treemacs-java-deps-list because they aren't support for my setup. I left symbols, references, and implementations alone because they have existing logic. Let me know if I can do anything else.

@marcantonio marcantonio mentioned this pull request Nov 6, 2022
Open
jcs090218
jcs090218 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LemonBreezes
Copy link

LGTM.

Hi. Do you know how to get this merged? It seems this has been approved for a while but never merged.

@nylar
Copy link

nylar commented Apr 3, 2024

@jcs090218 Any chance of getting this merged?

jcs090218
jcs090218 reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@jcs090218 jcs090218 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. This PR somehow goes under my radar. 🤔

lsp-treemacs.el Show resolved Hide resolved
@marcantonio
Copy link
Contributor Author

Updated. Ready to review again.

@jcs090218 jcs090218 merged commit f760681 into emacs-lsp:master Apr 5, 2024
11 of 12 checks passed
@jcs090218
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcantonio @LemonBreezes @nylar @jcs090218