Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix for #369 #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

svenssonaxel
Copy link

Work in progress: Fix for issue #369.

Theme changes won't update background color and fringe width
automatically. Previously, there was advice to delete frame after
load-theme. This commit changes this to instead update background
color and fringe width after load-theme and also after
custom-set-faces.

Note especially that

  • This fix is not tested with webkit.
  • If other features than :background are set in lsp-ui-doc-background
    face, then the inline mode might use them. Added documentation to
    advice against this.

Work in progress: Fix for issue emacs-lsp#369.

Theme changes won't update background color and fringe width
automatically. Previously, there was advice to delete frame after
load-theme. This commit changes this to instead update background
color and fringe width after load-theme and also after
custom-set-faces.

Note especially that
- This fix is not tested with webkit.
- If other features than :background are set in lsp-ui-doc-background
  face, then the inline mode might use them. Added documentation to
  advice against this.
@brotzeit
Copy link
Member

I will try to test this the next days.

@brotzeit brotzeit force-pushed the master branch 2 times, most recently from dfa421f to 134d9b7 Compare March 12, 2020 18:12
@tap349
Copy link

tap349 commented Dec 31, 2022

This problem still exists: changing color for lsp-ui-doc-background face has no effect on childframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants