make find-references behave better with simpler code #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might give it another stab current appearance of ref list is not as good as with tabulated mode |
zonuexe
approved these changes
Mar 10, 2019
phpactor.el
Outdated
| (erase-buffer) | ||
| (dolist (file-reference current-references) | ||
| (let ((path (plist-get file-reference :file)) | ||
| (x nil)) |
phpactor.el
Outdated
| (when path | ||
| (insert-text-button (phpactor-truncate-left path phpactor-references-list-col1-width) | ||
| 'action (lambda(x) (find-file path (plist-get reference :start))) | ||
| 'help-echo "mouse-2: visit this file in other window") |
There was a problem hiding this comment.
- If you ignore the argument, the variable name should be
_. - Please indent this line up properly.
- Separate between
lambdaand the argument list with a space.
|
I commented on details, but it looks good to me. |
ensime-mode has a similar implementation, which does not rely on tabulated mode and I liked the shorter implementation (grep-mode makes it easy to kill the buffer with a single keystroke). Besides, set-window-dedicated-p helps make the buffer sticky.
kermorgant
force-pushed
the
feature/improve-find-references
branch
from
e9c796e to
c303e8e
Compare
|
@zonuexe |
zonuexe
pushed a commit
that referenced
this pull request
Mar 25, 2019
ensime-mode has a similar implementation, which does not rely on tabulated mode and I liked the shorter implementation (grep-mode makes it easy to kill the buffer with a single keystroke). Besides, set-window-dedicated-p helps make the buffer sticky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensime-mode has a similar implementation, which does not rely on
tabulated mode and I liked the shorter implementation (+ grep-mode makes
it easy to kill the buffer with a single keystroke).
Besides, set-window-dedicated-p helps make the buffer sticky.
partly solves #98