Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mini-window height during phpactor-status #124

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

change mini-window height during phpactor-status #124

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e15841
change mini-window height during phpactor-status
Jul 2, 2019
2761df2
18 lines for phpactor-status is better
Jul 2, 2019
2b6dfd4
extract "magic value" to constant
Jul 5, 2019
5946ef1
fixup! extract "magic value" to constant
Jul 5, 2019
1cd8776
fixup! fixup! extract "magic value" to constant
Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions phpactor.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,7 @@ function."
(defun phpactor-status ()
"Execute Phpactor RPC status command, and pop to buffer."
(interactive)
(setq max-mini-window-height 18)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be enclosed by let?

(let ((max-mini-window-height 18))
  (apply #'phpactor-action-dispatch (phpactor--rpc "status" [])))

let temporarily overwrites variables and restores them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the literal value 18 a custom variable instead of a magic number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zonuexe done (with a note in the README about it)

(apply #'phpactor-action-dispatch (phpactor--rpc "status" [])))

;;;###autoload
Expand Down