composer require phpactor/phpactor:^0.11 #79

zonuexe · 2018-11-27T06:05:22Z

https://github.com/phpactor/phpactor/releases/tag/0.10.0

kermorgant · 2018-12-02T09:23:15Z

Hi @zonuexe
Sorry for being late, I've been quite busy last days. I will have a look at this in the coming days (I haven't used phpactor's develop branch since 0.9.0).

kermorgant · 2018-12-11T07:40:30Z

Hello,

Just gave it a shot :

running 'phpactor-update' took a significant time (makes me think a note in the README about that might be worth it)
restarted emacs and got this error in Phpactor Output

In Filesystem.php line 101:
                                                                               
  The "/home/mikael/src/phpactor.el/vendor/phpactor/phpactor/vendor/phpactor/  
  code-builder/templates" directory does not exist ("/home/mikael/src/phpacto  
  r.el/vendor/phpactor/phpactor/vendor/phpactor/code-builder/templates").

kermorgant

Hi @zonuexe

How did you handle the upgrade on your machine ?

At first sight, something did not work as expected on mine (see previous comment)

zonuexe · 2018-12-11T09:37:46Z

refs #80

#79 (review) According to the testimony of @ kermorgant, it seems that the installation was delayed due to the previous change and an error occurred.

kermorgant · 2018-12-11T10:25:05Z

composer.json

-        "phpactor/class-to-file": "@dev",
-        "phpactor/code-builder": "@dev",
+        "composer/xdebug-handler": "^1.1",
+        "monolog/monolog": "^1.0",


this one was problematic but after removing this line, installation would succeed

Suggested change

"monolog/monolog": "^1.0",

@kermorgant Thanks!

kermorgant · 2018-12-11T10:28:34Z

Running phpactor-status after upgrading generated an error with this message

phpactor-action-dispatch: Keyword argument :version not one of (:action :parameters)

My guess is that there's been a change in the RPC protocol, but I've asked @dantleech on slack to be sure.

kermorgant · 2018-12-11T10:39:29Z

@zonuexe as a sidenote :

I've started targeting develop branch for some pull requests to keep the freedom to experience a bit.

Could the develop branch be used for us as a staging phase for potentially disrupting changes, which I start to think this issue is

(I've been tempted to define the develop branch as the default one but as I was unsure about the scope of that change, I did not. Does that sound ok to make this switch ?)

zonuexe · 2018-12-11T10:43:47Z

@kermorgant
I agree to implement the experimental features in development branch. 👍
We can avoid destroying the environment of users who use MELPA instead of MELPA Stable.

kermorgant · 2018-12-11T10:53:19Z

@zonuexe thanks !

My guess is that there's been a change in the RPC protocol, but I've asked @dantleech on slack to be sure.

My bad, the issue disapeared after restarting emacs... (phpactor status works)

But still, trying completion ended with this message

{"version":"1.0.0","action":"error","parameters":{"message":"RecursiveDirectoryIterator::__construct(\/home\/mikael\/src\/phpactor.el\/vendor\/phpactor\/phpactor\/vendor\/jetbrains\/phpstorm-stubs): failed to open dir: No such file or directory","details":"0: RecursiveDirectoryIterator::__construct(\/home\/mikael\/src\/phpactor.el\/vendor\/phpactor\/phpactor\/vendor\/jetbrains\/phpstorm-stubs): failed to open dir: No such file or directory\n#0 \/home\/mikael\/src\/phpactor.el\/vendor\/phpactor\/worse-reflection\/lib\/Core\/SourceCodeLocator\/StubSourceLocator.php(87): RecursiveDirectoryIterator->__construct('\/home\/mikael\/sr...', 4096)\n#1 \/home\/mikael\/src\/phpactor.el\/vendor\/phpactor\/worse-reflection\/lib\/Core\/SourceCodeLocator\/StubSourceLocator.php(63): Phpactor\\WorseReflection\\Core\\SourceCodeLocator\\StubSourceLocator->fileIterator()\n#2 \/home\/mikael\/src\/phpactor.el\/vendor\/phpactor\/worse-reflection\/lib\/Core\/So....

jetbrains folder is to be found under vendor, not vendor/phpactor/vendor

zonuexe · 2018-12-11T10:57:44Z

I added jetbrains/phpstorm-stubs.

kermorgant · 2018-12-11T11:03:43Z

Thx !

Now facing this


In RpcExtension.php line 52:
                                                                               
  Handler "extension_manager.rpc.handler.list" must be provided with a "name"  
   attribute when it is registered

kermorgant · 2018-12-11T11:19:30Z

Just talked with @dantleech on slack

1- this error might need another tag for the extension-manager dependency
2- we probably should only require phpactor/phpactor which means we should find another way (than adding the dependencies ourself) to solve the path issues I referenced earlier

dantleech · 2018-12-11T16:27:55Z

we probably should only require phpactor/phpactor which means we should find another way (than adding the dependencies ourself) to solve the path issues I referenced earlier

You might want to try just falling back to ../../../ if the vendor directory doesn't exist here

kermorgant · 2018-12-12T13:42:08Z

@dantleech I tried and it worked. Is that an acceptable solution for a PR ?

dantleech · 2018-12-12T15:13:33Z

Yeah sure

kermorgant · 2018-12-14T11:22:56Z

Hi @zonuexe

You can revert to only requiring phpactor/phpactor (should be fixed whe this PR is merged)

kermorgant · 2018-12-21T12:31:14Z

@zonuexe you ca now target version 0.11.1 (thanks @dantleech ) which includes the path fix mentioned above.

kermorgant · 2018-12-24T17:40:55Z

@zonuexe I realized I had access to the branch so I pushed the change. OK for you ?

It is risky to overwrite the platform version, but now seems to work normally.

zonuexe · 2019-01-04T12:28:40Z

@kermorgant Sorry for the late reply.
I noticed that this Phpactor dependency can not be solved with PHP 7.3, but I think that perhaps there is no problem as unit testing is working in my environment.

kermorgant · 2019-01-04T12:55:33Z

No worry.
I solved that installation issue by doing composer install --no-dev --ignore-platform-reqs.

I understood the issue was related to a development dependency (php-cs-fixer I remember), which would anyway cause composer install --no-dev to fail. Thus, I think the error can be ignored (except the installation needs the ignore-platform-reqs, which I think should be done manually for the time being, no ?)

zonuexe · 2019-01-04T13:00:45Z

@kermorgant
It seems like the problem I saw. I would like to merge this change.

kermorgant · 2019-01-04T13:48:01Z

Ok for me ! Le ven. 4 janv. 2019 à 15:00, USAMI Kenta <[email protected]> a écrit :

…

@kermorgant <https://github.com/kermorgant> It seems like the problem I saw. I would like to merge this change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKEoLAQhbRC2yy8fihHvE2woMaEzkUOgks5u_1B-gaJpZM4Y0y4Z> .

zonuexe · 2019-01-04T13:48:58Z

@kermorgant Thanks a lot!

zonuexe requested a review from kermorgant November 27, 2018 06:05

kermorgant added the bug Something isn't working label Dec 11, 2018

kermorgant requested changes Dec 11, 2018

View reviewed changes

zonuexe added 2 commits December 11, 2018 18:38

composer require phpactor/phpactor:^0.10

3e036f3

composer require phpactor/phpactor:'^0.11' and expand dependencies

3cbc265

#79 (review) According to the testimony of @ kermorgant, it seems that the installation was delayed due to the previous change and an error occurred.

zonuexe force-pushed the phpactor-0.10 branch from 392d6d3 to 3cbc265 Compare December 11, 2018 09:49

kermorgant reviewed Dec 11, 2018

View reviewed changes

composer remove monolog/monolog

638acd8

zonuexe changed the title ~~composer require phpactor/phpactor:^0.10~~ composer require phpactor/phpactor:^0.11 Dec 11, 2018

composer require jetbrains/phpstorm-stubs:dev-master

2ac94d6

require phpactor 0.11.1

50c152a

Adopt dependency for PHP 7.3

fec3e59

It is risky to overwrite the platform version, but now seems to work normally.

zonuexe merged commit f21cfcf into master Jan 4, 2019

zonuexe deleted the phpactor-0.10 branch January 4, 2019 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

composer require phpactor/phpactor:^0.11 #79

composer require phpactor/phpactor:^0.11 #79

zonuexe commented Nov 27, 2018

kermorgant commented Dec 2, 2018

kermorgant commented Dec 11, 2018

kermorgant left a comment

zonuexe commented Dec 11, 2018

kermorgant Dec 11, 2018

zonuexe Dec 11, 2018

kermorgant commented Dec 11, 2018

kermorgant commented Dec 11, 2018

zonuexe commented Dec 11, 2018 •

edited

Loading

kermorgant commented Dec 11, 2018

zonuexe commented Dec 11, 2018

kermorgant commented Dec 11, 2018

kermorgant commented Dec 11, 2018

dantleech commented Dec 11, 2018 •

edited

Loading

kermorgant commented Dec 12, 2018

dantleech commented Dec 12, 2018

kermorgant commented Dec 14, 2018

kermorgant commented Dec 21, 2018

kermorgant commented Dec 24, 2018

zonuexe commented Jan 4, 2019

kermorgant commented Jan 4, 2019

zonuexe commented Jan 4, 2019

kermorgant commented Jan 4, 2019 via email

zonuexe commented Jan 4, 2019

composer require phpactor/phpactor:^0.11 #79

composer require phpactor/phpactor:^0.11 #79

Conversation

zonuexe commented Nov 27, 2018

kermorgant commented Dec 2, 2018

kermorgant commented Dec 11, 2018

kermorgant left a comment

Choose a reason for hiding this comment

zonuexe commented Dec 11, 2018

kermorgant Dec 11, 2018

Choose a reason for hiding this comment

zonuexe Dec 11, 2018

Choose a reason for hiding this comment

kermorgant commented Dec 11, 2018

kermorgant commented Dec 11, 2018

zonuexe commented Dec 11, 2018 • edited Loading

kermorgant commented Dec 11, 2018

zonuexe commented Dec 11, 2018

kermorgant commented Dec 11, 2018

kermorgant commented Dec 11, 2018

dantleech commented Dec 11, 2018 • edited Loading

kermorgant commented Dec 12, 2018

dantleech commented Dec 12, 2018

kermorgant commented Dec 14, 2018

kermorgant commented Dec 21, 2018

kermorgant commented Dec 24, 2018

zonuexe commented Jan 4, 2019

kermorgant commented Jan 4, 2019

zonuexe commented Jan 4, 2019

kermorgant commented Jan 4, 2019 via email

zonuexe commented Jan 4, 2019

zonuexe commented Dec 11, 2018 •

edited

Loading

dantleech commented Dec 11, 2018 •

edited

Loading