Rename only happens in post-command and recursion is prevented #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjensen
commented
May 20, 2020
|
The major issue is when I try to delete the whole word, it wouldn't delete the tag (whole word). Would it delete the whole word on your side? Thanks! |
|
It does for me, yes. Can you provide an example that does not currently work for you with this branch? |
aaronjensen
force-pushed
the
fix-recursion
branch
from
d1bd8ff
to
e1810e0
Compare
This may potentially cause very strange issues.
aaronjensen
force-pushed
the
fix-recursion
branch
from
e1810e0
to
d2e0642
Compare
|
@jcs090218 give this a shot. It's quite possibly a very bad idea. The other thing to try is to stash the changes we want to make somewhere during after-change and then apply them during the next post-command, which was the suggestion here: emacs-lsp/lsp-mode#1704 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
This may fix the issues you were seeing, it was possible for infinite recursion to happen which cause a stack error. This should prevent that.