Fixing jabber-roster-sort-items: roster shows items sorted now.

It was not using the jabber-roster-sort-functions properly: it didn't stop
at the first ordering result (first a < b as true). Now it execute until one
of the sorting criteria returns a < b or b > a.

jabber.el

@@ -3817,13 +3817,12 @@ JC is the Jabber connection."
 (defun jabber-roster-sort-items (a b)
   "Sort roster items A and B according to `jabber-roster-sort-functions'.
 Return t if A is less than B."
-  (dolist (fn jabber-roster-sort-functions)
-    (let ((comparison (funcall fn a b)))
-      (cond
-       ((< comparison 0)
-        t)
-       ((> comparison 0)
-        nil)))))
+  (let ((result nil))
+    (seq-find (lambda (fn)
+                (setq result (funcall fn a b))
+                (not (= result 0)))
+              jabber-roster-sort-functions)
+    (< result 0))))
 ;; jabber-roster-sort-items:1 ends here
 
 ;; [[file:jabber.org::#roster-sort-by-status][jabber-roster-sort-by-status:1]]

jabber.org

@@ -4743,22 +4743,14 @@ JC is the Jabber connection."
   (defun jabber-roster-sort-items (a b)
     "Sort roster items A and B according to `jabber-roster-sort-functions'.
   Return t if A is less than B."
-    (dolist (fn jabber-roster-sort-functions)
-      (let ((comparison (funcall fn a b)))
-        (cond
-         ((< comparison 0)
-          t)
-         ((> comparison 0)
-          nil)))))
+    (let ((result nil))
+      (seq-find (lambda (fn)
+                  (setq result (funcall fn a b))
+                  (not (= result 0)))
+                jabber-roster-sort-functions)
+      (< result 0))))
 #+END_SRC
 
-**** TODO Resolve warning
-byte-compiling function throws:
-
-: Warning: value returned from (< (funcall fn a b) 0) is unused
-
-What should we do with the returned value of each function?
-
 *** jabber-roster-sort-by-status                  :function:
 :PROPERTIES:
 :CUSTOM_ID: roster-sort-by-status