Fix Windows build #137
Closed
Fix Windows build #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of the test step
…t correctly; actually allocate space for the other HInfo that set_finfo reads, such as the times (cherry picked from commit 8b44b00)
… files, not just directories
…tting in side effecting AC_SUBST which won't get cached (cherry picked from commit 4b93738)
(cherry picked from commit cd269a9)
|
Although this failed on Travis, I've merged your branch into my branch for #131 and it looks like that fixed everything. Thank you so much for helping sort this out! Even if this has introduced some other minor issues, at least we have a sane build system now! |
This was referenced Oct 16, 2020
Merged
|
@rakslice I'd be much obliged if you can take 5 minutes to look at emaculation/shoebill#1 and see if that windows build is misconfigured in some obvious way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to get the emaculation codebase building in MSYS2. It is mostly changes cherry picked from out of kanjitalk755's master.
This is a sort of minimal set. Building is not to say working, this is a starting point for you.
If you have some other way of building that supports e.g. your
-mno-cygwinetc. that you want to stay compatible with you'll need to rework this to maintain compatibility.This PR includes the contents of #136.