Enable arm64-simulator slice creation in XCFramework by Carthage #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthage didn't create an ARM64 slice for simulators because the xcconfig file did specify which VALID_ARCHS should be build. Removing that specification did enable Carthage to build a slice for ARM64-simulator.
That was a huge problem because on M1/Apple Silicon machines generation of code coverage reports for tests is only possible when running an ARM64 app in the simulator. Without this change one could explore ARM for simulators and only run on x64 but loose code coverage with that trick.
VALID_ARCHS is outdated and no longer available/visible in current Xcode versions anyway.