Skip to content

fix compilation failure #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

Conversation

jnupeter
Copy link
Contributor

No description provided.

Signed-off-by: Peter Cai <[email protected]>
@jnupeter jnupeter force-pushed the fix-compliation-failure branch from 6b676f1 to 4421cbb Compare July 24, 2025 04:52
@jnupeter
Copy link
Contributor Author

@johnsonr or @alexheifetz , could you please review?

@alexheifetz
Copy link
Contributor

@jnupeter PR #20 fails to compile.

[ERROR] C:/alex-spring/embabel-space/coding-agent/src/main/kotlin/com/embabel/coding/domain/Reference.kt: (19, 1) Class 'ProjectReference' is not abstract and does not implement abstract member 'flushReads'.
[ERROR] C:/alex-spring/embabel-space/coding-agent/src/main/kotlin/com/embabel/coding/domain/Reference.kt: (41, 1) Class 'FilesReference' is not abstract and does not implement abstract member 'flushReads'.
[ERROR] C:/alex-spring/embabel-space/coding-agent/src/main/kotlin/com/embabel/coding/domain/SoftwareProject.kt: (39, 6) Class 'SoftwareProject' is not abstract and does not implement abstract member 'flushReads'.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35.230 s
[INFO] Finished at: 2025-07-25T11:27:15-04:00
[INFO] ------------------------------------------------------------------------

@jnupeter
Copy link
Contributor Author

@alexheifetz thanks for checking. I pushed a new change to uptake the newly added FileReadLog interface.

@alexheifetz
Copy link
Contributor

Thanks Peter. CI Build passes. Please signoff your commit and I will merge. it.
image

@jnupeter jnupeter force-pushed the fix-compliation-failure branch from f3a0274 to ed4623d Compare July 26, 2025 23:35
@alexheifetz alexheifetz merged commit 2820628 into embabel:main Jul 27, 2025
2 checks passed
@alexheifetz
Copy link
Contributor

Thanks @jnupeter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants