Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stm32: implement async flush for UART #3379

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

qwerty19106
Copy link
Contributor

  1. It implement non-blocking async flush for UART by enable Transmission complete interrupt.
  2. It consist fix for half-duplex: either tx or rx can be enabled one moment. The fix(stm32): disable transmitter during during half-duplex flush #3299 can be closed after merging it, because flush should get non-mutable reference. Flush should wait only, no more.

@qwerty19106
Copy link
Contributor Author

rebased

@Dirbaio
Copy link
Member

Dirbaio commented Oct 14, 2024

i've added on-hardware tests that test flush (just testing that it doesn't hang, it's hard to test that it actually waits...), let's see if they pass.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass! thanks for the PR :D

@Dirbaio Dirbaio added this pull request to the merge queue Oct 14, 2024
Merged via the queue into embassy-rs:main with commit 4f08d5b Oct 14, 2024
6 checks passed
@qwerty19106 qwerty19106 deleted the stm32_async_flush branch October 14, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants