Add set_config method to RP SPI driver
#3419
Conversation
embassy-rp/src/spi.rs
Outdated
|
|
||
| // change stuff | ||
| p.cpsr().write(|w| w.set_cpsdvsr(presc)); | ||
| p.cr0().write(|w| { |
There was a problem hiding this comment.
this is copypasted from new_inner. could you extract it to a private function fn apply_config() instead?
There was a problem hiding this comment.
After the CI failure, I see that the SetConfig trait in the embassy-embedded-hal actually does what I want, so this change may not be needed. Should we consider changing the trait implementation to disable/reenable the peripheral as the set_frequency method does?
There was a problem hiding this comment.
whatever's needed for it to work. I don't know if it's required
There was a problem hiding this comment.
The Pico SDK disables the driver before changing frequencies, as does the set_frequency method. I've updated to add a private apply_config method and then reused the Spi struct's set_config method in the trait implementation.
There was a problem hiding this comment.
This would also be a breaking change as the methods could conflict depending on Trait in scope or not - I propose we just remove the proposed Spi set_config method and update the Trait implementation to disable/reenable the driver at the expense of some code duplication - I'll wait for your thoughts before touching again. Thanks for all your work.
There was a problem hiding this comment.
don't worry about breaking changes, nextreleasewill be breaking anyway due to other changes.
|
Add a `set_config` method to `Spi` to allow reconfiguring SPI mode after creation. The existing implementation of the `embassy-embedded-hal` trait `SetConfig` is changed to use the new method. Existing uses of `SetConfig` trait may need to explicitly call the trait method to maintain current return type.
dstric-aqueduct
force-pushed
the
patch-1
branch
from
07e0f75
to
96362b3
Compare
Squashed all the commits and cleaned up the PR description. I think the CI is running cached tests so the modified |
Add a
set_configmethod toSpistruct to allow reconfiguring SPI mode after creation.The existing implementation of the
embassy-embedded-haltraitSetConfigis changed to use the new method.Existing uses of
SetConfigtrait may need to explicitly call the trait method to maintain current return type.