Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32U5: Add ADC drivers #3688

Merged
merged 17 commits into from
Dec 31, 2024
Merged

STM32U5: Add ADC drivers #3688

merged 17 commits into from
Dec 31, 2024

Conversation

klownfish
Copy link
Contributor

This pull request adds ADC drivers for the U5 series with both blocking and async reads. One quirk of the U5 series is that some models have two simultaneous revisions of the peripheral. To handle this I've had to touch the internals a bit. The issue in stm32-data has some more details.

Closes issue:
#3654

@Sandvoxel
Copy link

I just wanted to add that I’m also looking for ADC driver support for the STM32U5, as I plan to use the ADC in an upcoming project. Thanks for the work on this PR so far, and I’m looking forward to seeing it reviewed!

@Dirbaio
Copy link
Member

Dirbaio commented Dec 30, 2024

could you fix CI?

@klownfish
Copy link
Contributor Author

Should be fixed now! My first attempt failed so I did a force push to remove it from the history. I'm not entirely sure what's considered good practice with git but I hope it's okay.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@Dirbaio Dirbaio merged commit 18773c3 into embassy-rs:main Dec 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants