Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more examples for the esp32 platform.
It introduces an optional
esp32
feature to theexamples/apps
crate that influences the hardcoded L2CAP MTU and is intended to be set by the esp32 examples only. The current MTU of128
causes aBleHost(Hci(Unsupported Feature or Parameter Value))
error here when using an esp:trouble/host/src/host.rs
Lines 813 to 820 in aaf2d02
This is a known limitation, as seen in an issue comment over at the esp-idf repo espressif/esp-idf#942 (comment). They wrote that any total host buffer size <= 1021 bytes aren't safe to use (1017 bytes ACL MTU + 4 bytes ACL Data Packet header) as long as ACL packet segmentation isn't implemented, so I've set the MTU to 1017 if the
esp
feature is activated.I tested my changes with an ESP32C3 and ESP32S3 and in both cases I was able to use a lower MTU than 1017 but it still failed at 128 (200 failed too, 512 not)