Suvorov DM/accuracy verification #115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 78.44% 83.87% +5.42%
==========================================
Files 13 17 +4
Lines 348 552 +204
Branches 166 280 +114
==========================================
+ Hits 273 463 +190
- Misses 62 71 +9
- Partials 13 18 +5 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Please, do not attach binaries here (I mean images by themselves) |
src/layers/Tensor.cpp
Outdated
| if (t1.get_shape().count() != t2.get_shape().count()) return false; | ||
| if (t1.get_type() != t2.get_type()) return false; |
There was a problem hiding this comment.
I'd rather throw an error in this case, cause it is just invalid, not meaning that these tensors are not equal
app/accuracy_app/accuracy_check.cpp
Outdated
| #include <filesystem> | ||
|
|
||
| int main() { | ||
| std::string directory = "./photos"; |
There was a problem hiding this comment.
Accept directory as cmd line argument
app/accuracy_app/accuracy_check.cpp
Outdated
| cv::imshow("Image", image); | ||
| cv::waitKey(0); |
There was a problem hiding this comment.
This will show the images in a sequential order and block the execution. It is better not to do this. Our future application will not do that, actually.
What you need to do at this stage: read the content of the image, convert to tensor (cv::Mat -> Tensor, use our tensor class) and do nothing with this tensor (for now)
app/accuracy_app/accuracy_check.cpp
Outdated
| int main() { | ||
| std::string directory = "./photos"; | ||
|
|
||
| for (const auto& entry : std::filesystem::directory_iterator(directory)) { |
There was a problem hiding this comment.
namespace fs = std::filesystem;
I suggest using this, it is a common widely-used way to simplify std::filesystem related code
app/accuracy_app/accuracy_check.cpp
Outdated
| #include <iostream> | ||
| #include <filesystem> | ||
|
|
||
| int main() { |
There was a problem hiding this comment.
please create help message for users
app/accuracy_app/accuracy_check.cpp
Outdated
| #include <filesystem> | ||
|
|
||
| int main() { | ||
| std::string image_directory = "./photos"; |
There was a problem hiding this comment.
all paths need to be got from command line arguments
| std::string image_directory = "./photos"; | ||
|
|
||
| std::vector<cv::String> image_paths; | ||
| cv::glob(image_directory + "*.jpg", image_paths); |
I added a file with the opening of all photos in the directory.