Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1583 , I only changed the arguments of
get_fused_emebddings
, but forgot to update the internal implementation logic accordingly, which caused runtime errors. (Sorry)Now, they are fixed.
I will run
i
,t
, andit
encodings for each model to check.Checklist
make test
.make lint
.Checking progress:
salesforce-lavis
is conflict withsentence_transformers>=3.0