Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set use_instructions to True in models using prompts #1616

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

dbuades
Copy link
Contributor

@dbuades dbuades commented Dec 20, 2024

This PR sets the use_instructions parameter to True for models that use prompts.

I've also included Arctic models because, while they don’t explicitly mention prompts in their MTEB implementation, they add the prompts directly in their config_sentence_transformers.json, so SentenceTransformers uses them automatically (example here)

Additional context for this PR can be found in this thread

A follow up PR in the results repo updates the corresponding model_meta.json values for these specific models and revisions.

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Samoed

This comment was marked as outdated.

@dbuades
Copy link
Contributor Author

dbuades commented Dec 20, 2024

Thank you for the quick review @Samoed !

@Samoed Samoed merged commit 0c44482 into embeddings-benchmark:main Dec 20, 2024
10 checks passed
@dbuades dbuades deleted the feat/set-use-instructions branch December 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants