-
-
Notifications
You must be signed in to change notification settings - Fork 2
Support scenario testing #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
472eefc
to
20857ba
Compare
e90dc19
to
559a3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very close! let me know if you have any questions about this review and we can hop on a quick call 👍
devDependencies: { | ||
'ember-source': emberVersion, | ||
'@embroider/compat': '^4.0.3', | ||
'ember-cli': '^5.12.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why we're doing this because we need some ember-cli in the old versions but I don't think we benefit all that munch from having functions generate each of these scenarios. Can we just split it out to objects in the senarios array which will have a much clearer upgrade path for people used to ember-try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is that clearer?
with the functions, it's like... compatibility codified.
with "just objects", it applies every scenario has different compatibility requirements -- which isn't true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it is true depending on how far back you go 🤔 as you go back in the versions you need to make more and more changes e.g. https://github.com/mansona/ember-cli-notifications/blob/main/test-app/config/ember-try.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have some like.. shared database of these things somewhere -- centralized or something, in a library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I tried to add it to ember-try a while back but we're now off on a different path with @embroider/try
NOTE: The options that were attempted for resolving self-imports:
We've discussed that for a docs/demo app, we'd still want the code to look like it would to a consumer. We can do that via custom resolves in vite and tsconfig, but we should make that a separate concern from this PR. Using subpath imports for testing is good, and is fine since testing can have a lot of not-so-common situations to begin with. |
Silly nit - node 18 still? I suppose this is going back a way, so maybe that makes sense. |
Taken from https://github.com/html-next/ember-raf-scheduler/