Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for node < 16 #742

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions .github/workflows/CI.yml → .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,20 @@ on:
tags:
- "*"

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
lint:
name: "Linting"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: 16
cache: yarn
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn lint:js

Expand All @@ -25,13 +33,19 @@ jobs:
name: "Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: ["12"]
node-version:
- 16
- 18
- 20

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: yarn
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn test

Expand All @@ -40,13 +54,19 @@ jobs:
name: "PREFER_NATIVE=true Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: ["12"]
node-version:
- 16
- 18
- 20

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: yarn
- run: yarn install --frozen-lockfile --non-interactive
- run: PREFER_NATIVE=true yarn test

Expand All @@ -55,13 +75,19 @@ jobs:
name: "NATIVE_PROMISE=true Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: ["12"]
node-version:
- 16
- 18
- 20

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: yarn
- run: yarn install --frozen-lockfile --non-interactive
- run: NATIVE_PROMISE=true yarn test

Expand All @@ -70,13 +96,19 @@ jobs:
name: "Node Tests: ubuntu (node@${{ matrix.node-version }})"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: ["12"]
node-version:
- 16
- 18
- 20

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: yarn
- run: yarn install --frozen-lockfile --non-interactive
- run: yarn run test:node

Expand All @@ -88,7 +120,7 @@ jobs:
needs: ember-tests

strategy:
fail-fast: true
fail-fast: false
matrix:
ember-try-scenario:
- ember-lts-3.4
Expand All @@ -105,8 +137,9 @@ jobs:
allow-failure: true
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v4
with:
node-version: 12.x
node-version: 16
- name: install dependencies
run: yarn install
- name: test
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"typescript": "^4.1.3"
},
"engines": {
"node": ">= 10"
"node": "16.x || 18.x || >=20.x "
},
"publishConfig": {
"registry": "https://registry.npmjs.org/"
Expand All @@ -102,7 +102,7 @@
]
},
"volta": {
"node": "10.24.1",
"node": "16.20.2",
"yarn": "1.22.10"
}
}
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13209,9 +13209,9 @@ [email protected]:
integrity sha512-toV7q9rWNYha963Pl/qyeZ6wG+3nnsyvolaNUS8+R5Wtw6qJPTxIlOP1ZSvcGhEJw+l3HMMmtiNo9Gl61G4GVg==

workerpool@^2.3.0:
version "2.3.3"
resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-2.3.3.tgz#49a70089bd55e890d68cc836a19419451d7c81d7"
integrity sha512-L1ovlYHp6UObYqElXXpbd214GgbEKDED0d3sj7pRdFXjNkb2+un/AUcCkceHizO0IVI6SOGGncrcjozruCkRgA==
version "2.3.4"
resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-2.3.4.tgz#661335ded59a08c01ca009e30cc96929a7b4b0aa"
integrity sha512-c2EWrgB9IKHi1jbf4LG9sxKgHYOY+Ej5li6siEGtFecCXWG7eQOqATPEJ0rg1KFETXROEkErc1t5XiNrLG666Q==
dependencies:
object-assign "4.1.1"

Expand Down
Loading