Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐹 Migrate to ember 4 #1977

Merged
merged 5 commits into from
Dec 10, 2023
Merged

🐹 Migrate to ember 4 #1977

merged 5 commits into from
Dec 10, 2023

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Nov 5, 2023

Migrate to ember 4

Ember 3.x deprecations had to be removed to make this possible:

The unit test Unit | Service | head data: title with currentPage and currentSelect details is failing because of the ember 3.x deprecation computed-property.override.

I believe that:

  1. the test should be re-written with a mock of service:page instead of looking up for it and overriding its currentSection and currentPage CPs
  2. the test should belong to https://github.com/empress/guidemaker, not to https://github.com/ember-learn/guides-source, since the head-data service is defined there…

Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit bfea48b
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/65762c3a8d626c00082f069b
😎 Deploy Preview https://deploy-preview-1977--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bartocc bartocc changed the title Depend on ember-cli-fastboot@3+ 🐹 Migrate to ember 4 Nov 5, 2023
@bartocc
Copy link
Contributor Author

bartocc commented Nov 27, 2023

Hi there 👋 Anything I can do to help this PR go forward?

@bartocc bartocc marked this pull request as ready for review November 27, 2023 07:51
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mansona mansona merged commit 97b0981 into ember-learn:master Dec 10, 2023
3 checks passed
@bartocc bartocc deleted the ember-4 branch December 11, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants