Skip to content

Update dependency-injection.md #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions guides/release/applications/dependency-injection.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,12 @@ or application instance initializers (with the former being much more common).
For example, an application initializer could register a `Logger` factory with the key `logger:main`:

```javascript {data-filename=app/initializers/logger.js}
import EmberObject from '@ember/object';

export function initialize(application) {
let Logger = EmberObject.extend({
class Logger {
log(m) {
console.log(m);
}
});
}

application.register('logger:main', Logger);
}
Expand Down Expand Up @@ -118,12 +116,10 @@ register your factories as non-singletons using the `singleton: false` option.
In the following example, the `Message` class is registered as a non-singleton:

```javascript {data-filename=app/initializers/notification.js}
import EmberObject from '@ember/object';

export function initialize(application) {
let Message = EmberObject.extend({
text: ''
});
class Message {
text = '';
}

application.register('notification:message', Message, { singleton: false });
}
Expand All @@ -141,14 +137,12 @@ Once a factory is registered, it can be "injected" where it is needed.
Factories can be injected into whole "types" of factories with _type injections_. For example:

```javascript {data-filename=app/initializers/logger.js}
import EmberObject from '@ember/object';

export function initialize(application) {
let Logger = EmberObject.extend({
class Logger {
log(m) {
console.log(m);
}
});
}

application.register('logger:main', Logger);
application.inject('route', 'logger', 'logger:main');
Expand Down Expand Up @@ -190,9 +184,7 @@ This includes all of Ember's major framework classes, such as components, helper

### Ad Hoc Injections

Dependency injections can also be declared directly on Ember classes using `inject`.
Currently, `inject` supports injecting controllers (via `import { inject } from '@ember/controller';`)
and services (via `import { service } from '@ember/service';`).
Dependency injections can also be declared directly on Ember classes using `service` (via `import { service } from '@ember/service';`).

The following code injects the `shopping-cart` service on the `cart-contents` component as the property `cart`:

Expand Down Expand Up @@ -261,7 +253,7 @@ on a song's `audioType`.

```javascript {data-filename=app/components/play-audio.js}
import Component from '@glimmer/component';
import { getOwner } from '@ember/application';
import { getOwner } from '@ember/owner';

// Usage:
//
Expand Down