Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings with Ember 3.27 #70

Closed
boris-petrov opened this issue May 17, 2021 · 4 comments
Closed

Deprecation warnings with Ember 3.27 #70

boris-petrov opened this issue May 17, 2021 · 4 comments

Comments

@boris-petrov
Copy link
Contributor

All these usages cause Ember 3.27 to trigger deprecation warnings. It would be nice to have those fixed before Ember 4 as otherwise ember-classic-decorator won't be usable with it.

Somewhat related to #63.

@jherdman
Copy link

This is currently biting ember-metrics too. We're looking into refactor out our usages of @classic, but it'd be nice to be able to buy a little time.

@rwjblue
Copy link
Member

rwjblue commented Nov 5, 2021

I think you can add something like:

const _Ember = typeof require === 'function' && typeof require.has === 'function' && require.has('ember') ? require('ember') : Ember;

Then update those usages to use _Ember. I think most/all of those things are still available on the ember module's export just fine...

@lucacorti
Copy link

This is an issue for at least ember-metrics on 4.x which depends on e-c-d.

@boris-petrov
Copy link
Contributor Author

This has been fixed by #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants