Try requiring Ember if possible instead of using it as a global #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue ping. :) |
|
Anything I can do to help get a #70 fix merged? |
|
@rwjblue ping. :) |
|
I would love to see this merged as well. This might be the last issue preventing me from upgrading to Ember 4. I was able to clear all deprecations warnings in my app on Ember 3.28, besides this one:
The call stack indicates the warning comes from this library, which I can't remove quite yet due to other issues. |
|
This has been superseded by #89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
cc @rwjblue
I've copied what you gave in #70 as example code but I added
.defaultafter therequire- I believe it's necessary?