Uninstall ember-classic-decorator
#215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesfries
commented
Dec 22, 2021
| public init(...args: unknown[]): void { | ||
| this._super(...args); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| public constructor(...args: any[]) { |
There was a problem hiding this comment.
Tried using the unknown[] type here but I can't then call super() with that unknown type.
|
I can recall now why I used |
mikkopaderes
approved these changes
Dec 23, 2021
mikkopaderes
requested changes
Dec 23, 2021
There was a problem hiding this comment.
Let me hold off on this change. I'm applying it in #217 as I want to fix all deprecations in 1 PR so that we could see if the CI build succeeds. Once builds are succeeding then we could start looking into the bugfix PRs so that CI builds for them also succeeds.
|
@charlesfries I've applied this in #217. Thanks for providing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-classic-decoratorin its current state is not compatible with Ember 4 (the following PR will fix it but it's yet to be merged: emberjs/ember-classic-decorator#83)I think we are able to get by without it, but I'm going to do some research into Ember Data and Ember Simple Auth to make sure. Opening the PR anyways.