Display build results table at top of build results page #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
force-pushed
the
display-build-results-table
branch
from
0b33216
to
0ec6d6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 80.63% 80.67% +0.03%
==========================================
Files 131 133 +2
Lines 945 952 +7
==========================================
+ Hits 762 768 +6
- Misses 183 184 +1
Continue to review full report at Codecov.
|
|
@pgengler Is this still a WIP? I rebased. |
…elationship setup better
pgengler
force-pushed
the
display-build-results-table
branch
from
044819c
to
39017ca
Compare
…files, and fix offending files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the saved ember-try data (as collected in emberobserver/server#67) to display a result table. The motivation here is that when JSON-formatted result output becomes a part of ember-try for real (and not a hacked-on fork like we use now) the result table will no longer be displayed in the console output (being output to a JSON file instead). This will let us continue to display the results.
WIP.