Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "total score" and average score to maintainers page #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Feb 26, 2020

This PR is mostly to open up a discussion, the styling of the change isn't ready to be merged and I'm not even sure it's something that we would want to add 😂

Anyway, I saw someone share https://emberobserver.com/maintainers/rwjblue in the Community Discord and I thought "wow that is an impressive number of addons, but the number isn't big enough" 😂 so I thought a better metric would be to count up all the Ember Observer "points" that he has from each of the addons.

Screenshot 2020-02-26 at 08 03 24

I also thought this might serve as a slight gamification (especially with the average score) that might encourage more maintainers to update their addons, but I don't know 🤷‍♂

(also for the record @rwjblue does not need gamification to make him do more 🙈)

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #179 into master will decrease coverage by 0.32%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   80.63%   80.31%   -0.33%     
==========================================
  Files         131      132       +1     
  Lines         945      955      +10     
==========================================
+ Hits          762      767       +5     
- Misses        183      188       +5
Impacted Files Coverage Δ
app/components/total-score.js 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4548465...fcfb368. Read the comment docs.

@kategengler
Copy link
Member

I applaud the initiative but I really don't like showing a score for a person, especially because the maintainers page list shows any addon the username has been given access to on npm.

@mansona
Copy link
Contributor Author

mansona commented Feb 26, 2020

@kategengler feel free to close! I figured it might not be something that you would want to add and it only took me 10 mins anyway.

On a related note: if I wanted to make an app that showed these metrics would that be ok? or would that be an improper use of Ember Observer data or the API? 🤔

@kategengler
Copy link
Member

@mansona Well, there is no publicly supported API.

As I mentioned, that list is every addon a username on npm has access to, an "npm maintainer", not necessarily every addon a username takes ownership of -- For example, I assure you I have not even touched at least half of these addons https://emberobserver.com/maintainers/katiegengler

I understand the potential gamification, but I think a score based on that list may inadvertently cause people to remove their access from addons on npm, effectively increasing the bus-factor for those addons.

That said, I have wanted to improve the maintainers page: Get it to list addons the user commits to as well (tricky since npm and github usernames often differ), sort the addons by the quantity of contributions of that person, separate out the addons the user "owns" -- and for an ownership list, I would be ok with the score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants