Only remove TS deps when they are expected to need to be removed

embroider-build · Nov 10, 2024 · da52634 · da52634
1 parent 88170cd
commit da52634
Showing 1 changed file with 31 additions and 26 deletions.
diff --git a/index.js b/index.js
@@ -73,36 +73,41 @@ module.exports = {
         'ember-cli-sri',
         'ember-cli-terser',
         // Linting
+        // No longer needed because we explicitly define a babel config
         '@babel/plugin-proposal-decorators',
 
         // Upstream TypeScript blueprint is out of date, but
         // There is concensus on removing all this from the upstream blueprint as well.
-        '@types/ember',
-        '@types/ember-data',
-        '@types/ember-data__adapter',
-        '@types/ember-data__model',
-        '@types/ember-data__serializer',
-        '@types/ember-data__store',
-        '@types/ember__application',
-        '@types/ember__array',
-        '@types/ember__component',
-        '@types/ember__controller',
-        '@types/ember__debug',
-        '@types/ember__destroyable',
-        '@types/ember__engine',
-        '@types/ember__error',
-        '@types/ember__helper',
-        '@types/ember__modifier',
-        '@types/ember__object',
-        '@types/ember__owner',
-        '@types/ember__polyfills',
-        '@types/ember__routing',
-        '@types/ember__runloop',
-        '@types/ember__service',
-        '@types/ember__string',
-        '@types/ember__template',
-        '@types/ember__test',
-        '@types/ember__utils',
+        ...(options.typescript
+          ? [
+              '@types/ember',
+              '@types/ember-data',
+              '@types/ember-data__adapter',
+              '@types/ember-data__model',
+              '@types/ember-data__serializer',
+              '@types/ember-data__store',
+              '@types/ember__application',
+              '@types/ember__array',
+              '@types/ember__component',
+              '@types/ember__controller',
+              '@types/ember__debug',
+              '@types/ember__destroyable',
+              '@types/ember__engine',
+              '@types/ember__error',
+              '@types/ember__helper',
+              '@types/ember__modifier',
+              '@types/ember__object',
+              '@types/ember__owner',
+              '@types/ember__polyfills',
+              '@types/ember__routing',
+              '@types/ember__runloop',
+              '@types/ember__service',
+              '@types/ember__string',
+              '@types/ember__template',
+              '@types/ember__test',
+              '@types/ember__utils',
+            ]
+          : []),
       ].filter((depToRemove) => existingDeps.includes(depToRemove)),
       packageManager: options.packageManager,
     });