Allow direct importing of the standalone module #89
+4,305
−665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bundling content-tag tag in a WebWorker, building with rollup will not use the `browser` condition, and fallback to the node imports. We don't want that, so we need a way to import the explicit standalone build of content-tag.
driesdl
approved these changes
Dec 13, 2024
ef4
approved these changes
Dec 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bundling content-tag tag in a WebWorker, building with rollup will not use the
browsercondition, and fallback to the node imports. We don't want that, so we need a way to import the explicit standalone build of content-tag.babel-plugin-ember-template-compilation does something similar, here: https://github.com/emberjs/babel-plugin-ember-template-compilation/blob/main/package.json#L13