Skip to content

Commit

Permalink
fixing up entirely-skipped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ef4 committed Sep 7, 2024
1 parent 6fd39d4 commit e916a51
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
6 changes: 1 addition & 5 deletions tests/scenarios/engines-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,7 @@ let engineScenarios = appScenarios.map('engines', project => {
});

engineScenarios
.skip('lts_3_28-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged
.skip('lts_4_4-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged
.skip('release-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged
.skip('lts_5_8-engines') // this shouldn't be run
.skip('canary-engines') // this shouldn't be run
.skip()
.map('without-fastboot', () => {})
.forEachScenario(scenario => {
Qmodule(scenario.name, function (hooks) {
Expand Down
3 changes: 1 addition & 2 deletions tests/scenarios/fastboot-app-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,7 @@ appScenarios
merge(project.files, loadFromFixtureData('fastboot-app'));
})
// TODO remove once https://github.com/ember-fastboot/ember-cli-fastboot/issues/925 is fixed
.skip('lts_5_8-fastboot-app-test')
.skip('canary-fastboot-app-test')
.skip()
.forEachScenario(scenario => {
Qmodule(scenario.name, function (hooks) {
let app: PreparedApp;
Expand Down
15 changes: 6 additions & 9 deletions tests/scenarios/watch-mode-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,12 @@ import CommandWatcher, { DEFAULT_TIMEOUT } from './helpers/command-watcher';

const { module: Qmodule, test } = QUnit;

let app = appScenarios
.skip('canary')
.skip('lts_5_8')
.map('watch-mode', () => {
/**
* We will create files as a part of the watch-mode tests,
* because creating files should cause appropriate watch/update behavior
*/
});
let app = appScenarios.skip().map('watch-mode', () => {
/**
* We will create files as a part of the watch-mode tests,
* because creating files should cause appropriate watch/update behavior
*/
});

class File {
constructor(readonly label: string, readonly fullPath: string) {}
Expand Down

0 comments on commit e916a51

Please sign in to comment.