Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable] Add tests for export conditions #2098

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Sep 7, 2024

I didn't have any failures in

These pass as well -- so this means that if we were to use glimmer-vm's real packages, the correct build would appropriately be selected.


I'm trying to figure out why we're shipping the Dev version of the VM in production app builds, and this PR is exploring if we're losing export-condition compatibility somewhere.

See also:

Of note, where I've been testing this is old embroider/webpack, so it's possible that, by using vite, all our problems will go away.


From Ed in Discord:

apps don't even have these [glimmer-vm] packages in their dependency graph

So, the my whole hypothesis about using glimmer-vm's export conditions is out the window.
Idk if it makes sense to keep the tests though.

@NullVoxPopuli NullVoxPopuli changed the base branch from main to stable September 7, 2024 15:26
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review September 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant