Adding forced v2 packages feature #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a feature to `@embroider/shared-internals` so that the env var `EMBROIDER_FORCED_V2_PACKAGES` can cause any package to be interpreted as a v2 package regardless of what the package itself says. The purpose of this is to unblock testing of ember-source as a v2 addon. Current ember-source canary is formatted as a valid v2 addon except it doesn't declare itself to be one, because that would be potentially-breaking for people who are still consuming it via AMD and/or relying on the specific timing details of the classic vendor.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature to
@embroider/shared-internalsso that the env varEMBROIDER_FORCED_V2_PACKAGEScan cause any package to be interpreted as a v2 package regardless of what the package itself says.The initial motivating use case for this is that new-enough ember-source can function as a valid v2 addon despite not declaring itself to be a v2 addon, because that would be potentially-breaking for people who still consume it via AMD and/or depend on the specific timng of the classic vendor.js file. We don't want to break existing usage but we also want people on the bleeding edge to be able to take advantage of the capability.