Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was missing amdCompatibility #2118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Contributor

No description provided.

@mansona
Copy link
Member

mansona commented Sep 19, 2024

We're in the process of removing all this 🤔 #2103

@patricklx
Copy link
Contributor Author

mm, okay. But how are we going to use things like ember-fetch? especially if other addons are using it?

@patricklx
Copy link
Contributor Author

I guess I could just use my own import alias in vite

@mansona
Copy link
Member

mansona commented Sep 19, 2024

ember-fetch already doesn't work in Vite, and the blueprint already removes it

@patricklx
Copy link
Contributor Author

Well, it doesn't work by default, yes. But it can be made to work. Could also add a compat adapter maybe

@patricklx
Copy link
Contributor Author

mmm, i saw @ef4 had an alternative implementation idea for ember-fetch with embroider macros. maybe it's time to look at that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants