Support other plugins in keepAssets #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the keepAssets feature in `@embroider/addon-dev` so that it composes nicely with other plugins. For example, if you use a plugin that synthesizes CSS imports, it's nice for keepAssets to consume those and keep them as a real CSS files on disk when you build your addon.
|
@ef4 sorry if being silly here, is this smth we could document in readme.md of addon-dev package? |
|
Yes, good idea. The default way that this plugin is used in the v2-addon-blueprint doesn't change its public API at all, but I did also add a new optional argument. And we should probably explain this whole thing better. |
SergeAstapov
approved these changes
Oct 21, 2024
ef4
added a commit
to cardstack/glimmer-scoped-css
that referenced
this pull request
Oct 25, 2024
The rollup plugin as currently written only really works for library development, where you want to emit separate CSS files that are imported from your published JS files. But we'll also want to use it in apps, where those apps are building with Vite (or directly with Rollup). This PR simplifies the plugin so it just worries about emitting CSS and doesn't care exactly how that CSS gets further processed. To make this continue to work in v2 addons, I've [adjusted the implementaiton of the keepAssets plugin](embroider-build/embroider#2156) so that it will compose nicely with a plugin like this one that emits CSS. So you'll want to update `@embroider/addon-dev` to a version that includes that PR. In Vite, it just works with no further configuration since vite handles CSS imports out-of-the-box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the keepAssets feature in
@embroider/addon-devso that it composes nicely with other plugins.For example, if you use a plugin that synthesizes CSS imports, it's nice for keepAssets to consume those and keep them as a real CSS files on disk when you build your addon.