Disable build-logic

embulk · Sep 11, 2024 · 92e4310 · 92e4310
1 parent b9deee5
commit 92e4310
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 6 deletions.
diff --git a/build-logic-obsolete/README.md b/build-logic-obsolete/README.md
@@ -0,0 +1,7 @@
+The build-logic (equivalent to a Gradle plugin) does not seem to be required.
+
+Only adding a `TestEngine` in the test runtime classpath would load the `TestEngine` in the test.
+
+https://github.com/gradle/gradle/blob/v8.10.0/platforms/documentation/docs/src/docs/userguide/jvm/java_testing.adoc#filtering-test-engine
+
+https://github.com/gradle/gradle/tree/v8.10.0/platforms/documentation/docs/src/snippets/testing/junitplatform-engine
diff --git a/build-logic/build.gradle → build-logic-obsolete/build.gradle b/build-logic/build.gradle → build-logic-obsolete/build.gradle
diff --git a/build-logic/gradle.lockfile → build-logic-obsolete/gradle.lockfile b/build-logic/gradle.lockfile → build-logic-obsolete/gradle.lockfile
diff --git a/...mbulkJUnitPlatformTestClassProcessor.java → ...mbulkJUnitPlatformTestClassProcessor.java b/...mbulkJUnitPlatformTestClassProcessor.java → ...mbulkJUnitPlatformTestClassProcessor.java
diff --git a/...nitPlatformTestClassProcessorFactory.java → ...nitPlatformTestClassProcessorFactory.java b/...nitPlatformTestClassProcessorFactory.java → ...nitPlatformTestClassProcessorFactory.java
diff --git a/...it5/EmbulkJUnitPlatformTestFramework.java → ...it5/EmbulkJUnitPlatformTestFramework.java b/...it5/EmbulkJUnitPlatformTestFramework.java → ...it5/EmbulkJUnitPlatformTestFramework.java
diff --git a/...embulk/junit5/EmbulkPluginTestPlugin.java → ...embulk/junit5/EmbulkPluginTestPlugin.java b/...embulk/junit5/EmbulkPluginTestPlugin.java → ...embulk/junit5/EmbulkPluginTestPlugin.java
diff --git a/build.gradle b/build.gradle
@@ -1,6 +1,6 @@
 plugins {
     id "java"
-    id "embulk-plugin-test"
+    // id "embulk-plugin-test"
 }
 
 repositories {
@@ -14,10 +14,11 @@ configurations {
     compileClasspath.resolutionStrategy.activateDependencyLocking()
     runtimeClasspath.resolutionStrategy.activateDependencyLocking()
 
-    embulkTestImplementation.extendsFrom testImplementation
-    embulkTestRuntime.extendsFrom testRuntime
+    // embulkTestImplementation.extendsFrom testImplementation
+    // embulkTestRuntime.extendsFrom testRuntime
 }
 
+/*
 sourceSets {
     embulkTest {
         java {
@@ -26,15 +27,16 @@ sourceSets {
         resources.srcDir file("src/embulkTest/resources")
     }
 }
+*/
 
 dependencies {
     testImplementation "org.junit.jupiter:junit-jupiter-api:5.11.0"
 
     testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:5.11.0"
 
-    embulkTestImplementation "org.junit.jupiter:junit-jupiter-api:5.11.0"
+    // embulkTestImplementation "org.junit.jupiter:junit-jupiter-api:5.11.0"
 
-    embulkTestRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:5.11.0"
+    // embulkTestRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:5.11.0"
 }
 
 // A safer and strict alternative to: "dependencies" (and "dependencies --write-locks")
@@ -65,6 +67,7 @@ test {
     }
 }
 
+/*
 task embulkTest(type: Test) {
     classpath = sourceSets.embulkTest.runtimeClasspath
     testClassesDirs = sourceSets.embulkTest.output.classesDirs
@@ -80,3 +83,4 @@ task embulkTest(type: Test) {
         outputs.upToDateWhen { false }
     }
 }
+*/
diff --git a/settings.gradle b/settings.gradle
@@ -1,4 +1,4 @@
 rootProject.name = "embulk"
-includeBuild "build-logic"
+// includeBuild "build-logic"
 include "embulk-junit5-api"
 include "embulk-junit5-engine"