Parse JSON into org.embulk.spi.json.JsonValue, not org.msgpack.value.Value #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroyuki-sato
approved these changes
Sep 25, 2023
| if (task.getFlattenJsonArray()) { | ||
| if (!value.isArrayValue()) { | ||
| if (!value.isJsonArray()) { | ||
| throw new JsonRecordValidateException( | ||
| String.format( | ||
| "A Json record must represent array value with '__experimental__flatten_json_array' option, but it's %s", |
There was a problem hiding this comment.
Offtopic: __experimental__flatten_json_array -> flatten_json_array
There was a problem hiding this comment.
Thanks for your good catch! Exactly. Fixed it in: b8039b4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in
embulk-util-json, we are going to releaseembulk-parser-json:0.11.1just with dropping use oforg.msgpack.value.Value, but without one-path parsing.This pull request includes :
JsonParserto newJsonValueParser, with replacing use oforg.msgpack.value.Valuetoorg.embulk.spi.json.JsonValueorg.embulk.spi.json.JsonValue, withoutorg.msgpack.value.ValueEach step is tested as an independent commit on CI.
embulk-parser-json:0.11.1would be released with this, and also Embulk v0.11.1.