Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess with org.embulk.spi.json.JsonValue, instead of org.msgpack.value.Value #9

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Guess with org.embulk.spi.json.JsonValue, instead of org.msgpack.value.Value #9

merged 1 commit into from
Sep 25, 2023
+12 −13

Conversation

dmikurube
Copy link
Member

No description provided.

@dmikurube dmikurube added this to the v0.11.1 milestone Sep 22, 2023
@dmikurube dmikurube requested a review from a team as a code owner September 22, 2023 01:54
hiroyuki-sato
hiroyuki-sato approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Base automatically changed from parse-to-JsonValue to main September 25, 2023 12:58
@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit ed21b99 into main Sep 25, 2023
4 checks passed
@dmikurube dmikurube deleted the guess-with-JsonValue branch September 25, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikurube @hiroyuki-sato